Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/data 2002 generalise jinja params #42

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

siklosid
Copy link
Member

@siklosid siklosid commented Jul 4, 2024

DATA-2002

  1. Adding new parameter to the module config generator, so now we can pass any number of json files to the generator, which will be accessible from the jinja template as parameters.
  2. Enabling using airflow's task group feature which helps visually grouping airflow tasks on the airflow UI. This will make our test graph a little bit easier to navigate especially after we move the tasks into their respective marts.

@siklosid siklosid requested a review from a team as a code owner July 4, 2024 14:23
Copy link

swarmia bot commented Jul 4, 2024

Copy link
Member

@kiranvasudev kiranvasudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !!

left two comments

dagger/cli/module.py Show resolved Hide resolved
dagger/utilities/module.py Outdated Show resolved Hide resolved
Copy link
Member

@kiranvasudev kiranvasudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

@siklosid siklosid merged commit f041aa8 into master Jul 4, 2024
1 check passed
@siklosid siklosid deleted the feature/DATA-2002_generalise_jinja_params branch July 4, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants