Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-1996: adjust the dbt config parser so that view/ephemeral staging layer doesnt need a task #41

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

claudiazi
Copy link

@claudiazi claudiazi commented Jun 18, 2024

Adjust the dbt config parser so that:

  • If the node is a DBT source, an Athena table task is generated.
  • If the node is an ephemeral model, a dummy task is generated, and tasks for its dependent nodes are recursively generated.
  • If the node is a staging model (preparation model) and not materialized as a table, a table task is generated along with tasks for its dependent nodes.
  • For other nodes, a table task is generated. If the node is materialized as a table, an additional S3 task is also generated.

Tested in airflow-staging
example:
Screenshot 2024-06-18 at 09 40 14

@claudiazi claudiazi requested a review from a team as a code owner June 18, 2024 07:40
Copy link

swarmia bot commented Jun 18, 2024

✅  Linked to Bug DATA-1996 · Improve the dbt-preparation dag

dagger/utilities/dbt_config_parser.py Outdated Show resolved Hide resolved
dagger/utilities/dbt_config_parser.py Outdated Show resolved Hide resolved
dagger/utilities/dbt_config_parser.py Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 18, 2024
@claudiazi claudiazi requested review from kiranvasudev and a team June 18, 2024 15:23
Copy link
Member

@kiranvasudev kiranvasudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@claudiazi claudiazi merged commit 81e75da into master Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants