-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jiff support #243
Add jiff support #243
Conversation
Chrono doesn't have anything like The If you want to serialize something like Otherwise, just serializing a |
Thanks for jumping onto this issue 👍 I just read your comment on the issue re "Z" suffix and am still digesting the nuances - I have the feeling I should sit down at some point an truly understand timezones. At this moment, I only support (naive) datetimes without timezone and datetimes with UTC timezone. The comment was about finding a common format between chrono and jiff that allows to deserialize strings encoding a timestamp in UTC to either Edit.: |
So, there is a distinction between "datetime in UTC time zone" and "datetime in Zulu." Conversely, when you serialize a UTC is itself not really a time zone, it's a time scale. Confusingly, it is common to use UTC as if it were a time zone (including in Jiff, which inherits this from the IANA Time Zone Database itself). But it's usually semantically wrong even though it will give the same, in practice, results. But a Note: "civil time" is equivalent to "local" or "naive" or "plain" time used in other datetime libraries.
Yes. That's not inconsistent with what I said. :-) What doesn't support Serde is For Basically, you should only be supporting |
Thanks a lot for the detailed explanation. I will have to let it settle for a bit. Luckily, I am still fighting with the civil types ;) |
If you're interested, my handle is |
Thanks for the offer. I will close the laptop for today, but will definitely ping you, once I look into this issue again. |
Implement #213
jiff::Date
jiff::Time
jiff::DateTime
jiff::Timestamp
jiff::Span
Duration
) and calendar interval durations (arrow:Interval
)jiff::SignedDuration
jiff::Zoned
Allow to maprequires breaking changes, implement as part of [breaking] FixDate
toDate64
Date64
semantics #240test_with_arrow
tree