Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Fix Date64 semantics #240

Open
Tracked by #238
chmp opened this issue Sep 30, 2024 · 1 comment
Open
Tracked by #238

[breaking] Fix Date64 semantics #240

chmp opened this issue Sep 30, 2024 · 1 comment

Comments

@chmp
Copy link
Owner

chmp commented Sep 30, 2024

Use Timestamp as the default type for detected date time objects

Removes a lot of the strategy logic and simplifies the overall mapping

  • Use Timestamp(..., Some("UTC")) for UTC times
  • Use Timestamp(..., None) for naive date times
  • Use Date64 for naive dates
  • Remove the strategy logic
  • Note: Date64 is incorrectly used to represent timestamps, it should actually be date and count the number of days ("values of Date64 are treated as the number of days, in milliseconds, since the UNIX epoch. Therefore, values of this type must be evenly divisible by 86_400_000, the number of milliseconds in a standard day.")
@chmp chmp mentioned this issue Oct 2, 2024
14 tasks
@chmp chmp changed the title [brekaing] Switch to Timestamp as the default type for deteteced date time objects, make Date64 naive only [breaking] Fix Date64 semantics Oct 4, 2024
@chmp chmp mentioned this issue Oct 4, 2024
11 tasks
@chmp chmp mentioned this issue Jan 19, 2025
25 tasks
@chmp
Copy link
Owner Author

chmp commented Jan 19, 2025

Work started in #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant