Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Selinux Prop spoofing #470

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

DanGLES3
Copy link
Contributor

@DanGLES3 DanGLES3 commented Nov 7, 2024

I'd suggest either removing this line of code or have it set the property to 1 (which shouldn't be problematic as it's present on some stock ROMs) so it doesn't alarm detection systems and doesn't cause property deletion detection

I'd suggest either removing this line of code or have it set the property to 1, which by itself shouldn't problematic as it's present on some stock ROMs thus doesn't alarm detection systems and doesn't cause property deletion detection
@osm0sis
Copy link
Contributor

osm0sis commented Nov 10, 2024

Resolved in upstream PIFork scripts with a user option:
osm0sis@cd32f0c

For more context:
osm0sis#19

@Fede2782
Copy link

This should be applied in any case as it breaks Samsung Selinux information. The property should not exist on non-One UI while it has to be 1 when in One UI.

@osm0sis
Copy link
Contributor

osm0sis commented Nov 13, 2024

Back in the MagiskHide days topjohnwu found that it was also set to 0 on some stock ROMs with SELinux enforcing. So both 0 or 1 could mean SELinux was enabled in the build, depending on the ROM, which is why he just chose to delete it.

Some further context and debate throughout this USNF PR thread: kdrag0n/safetynet-fix#166 (comment)

@chiteroman chiteroman merged commit e1ced60 into chiteroman:main Nov 16, 2024
1 check passed
@b0l5
Copy link

b0l5 commented Nov 17, 2024

I can't pass attestation, so I must remove this file: ro.build.selinux?

@ScottRFrost
Copy link

I can't pass attestation, so I must remove this file: ro.build.selinux?

Where is the file located?

@b0l5
Copy link

b0l5 commented Nov 22, 2024

I can't pass attestation, so I must remove this file: ro.build.selinux?

Where is the file located?

I don't know.

@OpM3TA
Copy link

OpM3TA commented Nov 28, 2024

I can't pass attestation, so I must remove this file: ro.build.selinux?

Where is the file located?

I don't know.

It's not a file lol it's a build property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants