Adding new config fragments to Rocket-chip subsystem Config.scala #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
force-pushed
the
NewSubsystemConfigFragments
branch
from
c519fd0
to
5a4213f
Compare
|
Do you mind taking a look at #3655 ? That PR is intended to DRY out all these new configs, and compartmentalize them in the rocket subpackage. |
|
I like the look of it, feels a lot cleaner to create new configs-snippets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
As asked by Jerry in issue #3647, submitting several config-fragments that I have created while working in chipyard. Some of the fragments I've created are for enabling features and some are more QoL to give more customization to existing features. Happy to remove any of them if they are too verbose.