Add is_certificate and export_cdi flags to DeriveContext #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
commented
Dec 26, 2024
| @@ -20,6 +20,7 @@ disable_csr = [] | |||
| disable_internal_info = [] | |||
| disable_internal_dice = [] | |||
| disable_retain_parent_context = [] | |||
| disable_export_cdi = [] | |||
There was a problem hiding this comment.
The specification has a separate ABI if EXPORT_CDI is set.
Should this compilation flag also change the shape of the DeriveContextResp type?
clundin25
force-pushed
the
feature/gh-issue-caliptra-sw-1807
branch
from
c4459df to
637686d
Compare
As well as other boiler plate work to make sure the invariants laid out in the spec are enforced.
clundin25
force-pushed
the
feature/gh-issue-caliptra-sw-1807
branch
from
637686d to
2fa1379
Compare
|
Will follow up with clean up / refactors once most of the feature work is out of the way. |
clundin25
force-pushed
the
feature/gh-issue-caliptra-sw-1807
branch
2 times, most recently
from
53e83d4 to
0b856e1
Compare
…guish the exported CDI from the DPE CDI. Use this new API to create the exported CDIs keypair
clundin25
force-pushed
the
feature/gh-issue-caliptra-sw-1807
branch
from
0b856e1 to
392b65f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as other boiler plate work to make sure the invariants laid out in the spec are enforced.