Csg/feature/get-pase-data-via-rpc #27
Conversation
This reverts commit 2fa503a.
Csg/feature/initial xml rpc support
Add document describing the dev/admin flow and building and testing
RPC methods for Resolve and Zcl - AddNetwork and EnableNetwork implemented.
wahajsyed
changed the title
wahajsyed
requested review from
mikaelhm,
nirav1911,
SaileeG,
cjandhyala and
Xiole-KKE
|
|
||
| std::string PAKE_3_key ("PAKE3"); | ||
|
|
||
| const char * yaml_string_for_map(std::map<std::string, std::map<std::string, std::string>> *trace_map) |
There was a problem hiding this comment.
I wonder if there is a library or something that does this for us? Worried if there are any edge cases that might bite us.
There was a problem hiding this comment.
Filed #28 to investigate
There was a problem hiding this comment.
| return response; | ||
| } | ||
|
|
||
| std::string stringForDataBuffer(const uint8_t *start, uint16_t data_length) |
There was a problem hiding this comment.
can you rename it to string_for_data_buffer following c++ code convention
| } | ||
| } | ||
|
|
||
| char * response = new char [result_yaml_str.length()+1]; |
There was a problem hiding this comment.
can you use std::string instead of new char ? the mem allocated with new is not freed anywhere
There was a problem hiding this comment.
We need to return a char * here so we can stick with supported ctypes primitives std:string and c++ data types are not supported.
You are right, we need to figure out a way to free this memory
|
@cjandhyala - Added a todo to free the memory in the other PR, due to time sensitivity will address the issue in a later pr |
|
Closing this PR, with newer PR: https://github.com/chip-csg/connectedhomeip/pull/30/files |
Problem
Implement hooks to trace and send PASE data
Summary of Changes
RPC to fetch PASE data
Changes to the SDK to trace and save the PASE data
Fixes #25