[BREAKING] position flavour text divider #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndepaola
force-pushed
the
flavour-text-divider
branch
from
9082087 to
15512c3
Compare
ndepaola
force-pushed
the
flavour-text-divider
branch
from
5a6d40c to
70bbd22
Compare
ndepaola
force-pushed
the
flavour-text-divider
branch
from
82ff5dc to
f668735
Compare
ndepaola
force-pushed
the
flavour-text-divider
branch
from
702b550 to
8d59f30
Compare
jorgebraz
reviewed
Feb 9, 2023
| * This method is slighty imperfect because of how the shape of the text layer can affect how flavour text is positioned, but should be close enough. | ||
| */ | ||
|
|
||
| if (this.flavour_text.length !== "") { |
There was a problem hiding this comment.
Might want to test either for length if (this.flavour_text.length) or for flavour text not being empty string if (this.flavour_text !== "". As it stands now script seems to fail for cards with no flavour text.
Great work with this PR though 💪 super useful 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BREAKING] here refers to the fact that this PR will not work with current templates - they will need to be updated with the required layer. I'll hold off on merging this until I update all templates for compatibility.
Example of automatically positioned divider: