Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use match expressions in mapLegacyValues #31

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

kauhat
Copy link
Contributor

@kauhat kauhat commented Aug 2, 2024

Hi, thank you for making this package.

It looks like use of str_replace in the mapLegacyValues() method can lead to some values being partially substituted (e.g. "inACTIVE".)

To avoid this I have replaced these with PHP 8.0+ match expressions. They seem like a nice fit for this.

This change should fix the following issues:

@chiiya
Copy link
Owner

chiiya commented Sep 6, 2024

Sorry for the late response, but thanks!

@chiiya chiiya merged commit 4560651 into chiiya:master Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants