Merge pull request #197 from gunsch/webidl-conversions

Fixes cjs-to-esm for exports with spaces in their names.
chialab · Nov 4, 2024 · 8e82ec2 · 8e82ec2
2 parents b7b1468 + 60e95b1
commit 8e82ec2
Show file tree

Hide file tree

Showing 4 changed files with 470 additions and 1 deletion.
diff --git a/.changeset/great-rules-boil.md b/.changeset/great-rules-boil.md
@@ -0,0 +1,7 @@
+---
+'@chialab/cjs-to-esm': patch
+'@chialab/esbuild-plugin-commonjs': patch
+'@chialab/vite-plugin-commonjs': patch
+---
+
+Fixes handling of CJS modules that export identifiers with spaces.
diff --git a/packages/cjs-to-esm/lib/index.js b/packages/cjs-to-esm/lib/index.js
@@ -324,7 +324,7 @@ if (${conditions.join(' && ')}) {
     ${named.map((name, index) => `__export${index} = module.exports['${name}'];`).join('\n    ')}
 }`);
 
-            helpers.append(`\nexport { ${named.map((name, index) => `__export${index} as ${name}`).join(', ')} }`);
+            helpers.append(`\nexport { ${named.map((name, index) => `__export${index} as "${name}"`).join(', ')} }`);
         }
         if (isEsModule) {
             if (!isUmd && (hasDefault || named.length === 0)) {