♲ Stop handling EINTR around time.sleep()
#652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 82.61% 82.61%
=======================================
Files 28 28
Lines 4062 4062
=======================================
Hits 3356 3356
Misses 706 706 |
webknjaz
force-pushed
the
refactoring/ioerror-drop
branch
from
e57093c to
232e404
Compare
`IOError` is an alias of `OSError` since Python 3.3. Python 3 also
indroduced a new exception `InterruptedError` which represents
`EINTR`. The `time.sleep()` call could raise
IOError: [Errno 4] Interrupted function call
on KBInt under Python 2, which would be `InterruptedError` under
Python 3 but it's not raised anymore post PEP 475 that was implemented
in Python 3.5. So it does not actually need to be handled in modern
runtimes.
Refs:
* https://stackoverflow.com/a/52613818/595220
* https://peps.python.org/pep-0475/
* python/cpython#56671
* https://stackoverflow.com/a/38258781/595220
* https://docs.python.org/3/library/exceptions.html#InterruptedError
* python/cpython#36893
webknjaz
force-pushed
the
refactoring/ioerror-drop
branch
from
232e404 to
f822e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOErroris an alias ofOSErrorsince Python 3.3. Python 3 also indroduced a new exceptionInterruptedErrorwhich representsEINTR. Thetime.sleep()call could raiseon KBInt under Python 2, which would be
InterruptedErrorunder Python 3 but it's not raised anymore post PEP 475 that was implemented in Python 3.5. So it does not actually need to be handled in modern runtimes.Refs:
This change is