Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§ͺ Stop tagging codecov uploads w/ wheel name #650

Merged
1 commit merged into from
Mar 13, 2024

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Mar 12, 2024

This seems to be what's breaking the uploader. It's likely because it's getting too long for Codecov to handle.

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

N/A

❓ What is the current behavior? (You can also link to an open issue here)

Codecov uploads from GHA fail.

❓ What is the new behavior (if this is a feature change)?

Well, they shouldn't anymore.

πŸ“‹ Other information:

Codecov is weird about what can be a flag name and they seem to have some length/char restrictions that they don't communicate clearly.

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

This seems to be what's breaking the uploader. It's likely because
it's getting too long for Codecov to handle.
@webknjaz webknjaz added the enhancement Improvement label Mar 12, 2024
@webknjaz webknjaz self-assigned this Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #650 (f011b8e) into main (0fd16f0) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #650   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files          28       28           
  Lines        4039     4039           
=======================================
  Hits         3347     3347           
  Misses        692      692           

@webknjaz webknjaz marked this pull request as ready for review March 13, 2024 10:38
@webknjaz webknjaz closed this pull request by merging all changes into cherrypy:main in 37c2196 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant