failed example for logcumsumexp (tinygrad#6936)

need cummax for numerical stability
chenyuxyz · Oct 7, 2024 · e4c0743 · e4c0743
1 parent 102dfe5
commit e4c0743
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/test/test_ops.py b/test/test_ops.py
@@ -1080,6 +1080,10 @@ def test_logcumsumexp(self):
     helper_test_op([()], lambda x: torch.logcumsumexp(x, dim=0), lambda x: x.logcumsumexp(), atol=1e-7, grad_atol=1e-7)
     helper_test_op([()], lambda x: torch.logcumsumexp(x, dim=-1), lambda x: x.logcumsumexp(-1), atol=1e-7, grad_atol=1e-7)
 
+  @unittest.expectedFailure  # TODO: fix numerical instability
+  def test_logcumsumexp_numerical(self):
+    helper_test_op(None, lambda x: torch.logcumsumexp(x, dim=0), lambda x: x.logcumsumexp(), atol=1e-7, grad_atol=1e-7, vals=[[0.0, 100.0]])
+
   def test_sinh(self):
     helper_test_op([(45,65)], lambda x: x.sinh(), grad_atol=1e-6)
     # TODO: backward nan instead of inf