fix bugs in update_sku

chengliangli0918 · Apr 6, 2024 · 33f69b0 · 33f69b0
1 parent 2a8094d
commit 33f69b0
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py b/src/aks-preview/azext_aks_preview/managed_cluster_decorator.py
@@ -3197,12 +3197,10 @@ def set_up_sku(self, mc: ManagedCluster) -> ManagedCluster:
         skuName = self.context.get_sku_name()
         if skuName is not None and skuName == CONST_MANAGED_CLUSTER_SKU_NAME_AUTOMATIC:
             mc.sku.name="Automatic"
-            # passive Kind should always to match sku.name
             mc.kind="Automatic"
             mc.sku.tier="Standard"
         else:
             mc.sku.name="Base"
-            # passive Kind should always match sku.name
             mc.kind="Base"
             mc.sku.tier="Free"
 
@@ -4459,16 +4457,22 @@ def update_sku(self, mc: ManagedCluster) -> ManagedCluster:
         :return: the ManagedCluster object
         """
         self._ensure_mc(mc)
+
+        # there are existing MCs with nil sku, that is Base/Free
+        if mc.sku is None:
+            mc.sku = self.models.ManagedClusterSKU(
+                sku="Base",
+                tier="Free",
+            )
+
         skuName = self.context.get_sku_name()
-        mc.sku = self.models.ManagedClusterSKU()
         if skuName is not None and skuName == CONST_MANAGED_CLUSTER_SKU_NAME_AUTOMATIC:
+            # Existing Automatic SKU or switch from Base to Automatic SKU
             mc.sku.name="Automatic"
-            # passive Kind should always to match sku.name
             mc.kind = "Automatic"
-            mc.sku.tier="Standard"
         else:
+            # Existing Base SKU or switch from Automatic to Base SKU
             mc.sku.name="Base"
-            # passive Kind should always match sku.name
             mc.kind="Base"
 
         # Premium without LTS is ok (not vice versa)