-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forms): add sample 'conditional' #258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoooooooo, lovely, will take a look tonight <3 |
cheleb
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound great, just maybe remove data when condition is not met any longer, look inline suggestion.
Ok I think it is ready to be merged. |
Thanks you ! |
Merged, I've push my suggestion just after.
Thanks again.
…On Mon, Jan 20, 2025 at 2:21 PM guillaug ***@***.***> wrote:
Ok I think it is ready to be merged.
Let me know.
—
Reply to this email directly, view it on GitHub
<#258 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4NK42EUHJGO3M2SR324D2LTZ6HAVCNFSM6AAAAABVJKPBEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBSGQYTINZYGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
"Computers are useless. They can only give you answers."
- Pablo Picasso -
|
FYI https://github.com/cheleb/laminar-form-derivation/releases/tag/v0.22.0
On Mon, Jan 20, 2025 at 2:41 PM Olivier NOUGUIER ***@***.***>
wrote:
… Merged, I've push my suggestion just after.
Thanks again.
On Mon, Jan 20, 2025 at 2:21 PM guillaug ***@***.***> wrote:
> Ok I think it is ready to be merged.
> Let me know.
>
> —
> Reply to this email directly, view it on GitHub
> <#258 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAC4NK42EUHJGO3M2SR324D2LTZ6HAVCNFSM6AAAAABVJKPBEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBSGQYTINZYGY>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
"Computers are useless. They can only give you answers."
- Pablo Picasso -
--
"Computers are useless. They can only give you answers."
- Pablo Picasso -
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think of adding this feature : conditionally showing a field (label and value) depending on the value of a variable.
I made an example that show 2 extra fields of type 'String' and 'Int' if the age of the person is older than 18.
See 'Conditional' tab in the examples / samples