New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort MultiIndex to improve performance #124

Open

cinabars wants to merge 2 commits into cheind:develop from cinabars:develop

Contributor

cinabars commented Sep 11, 2020

Sorting a MultiIndex dataframe improves performance. In some cases, indexing a MultiIndex dataframe without sorting can even throw an UnsortedIndexError, so this change prevents that from occuring. (source: https://pandas.pydata.org/pandas-docs/stable/user_guide/advanced.html#sorting-a-multiindex)

ezhu added 2 commits

September 11, 2020 02:35


          lexsort multiindex

5360c40


          remove pycharm files

bf3902a

Owner

cheind commented Sep 12, 2020

Hey thanks for the PR!

Couple of comments:

Calling sort_index in new_event_dataframe is not doing anything as the dataframe is empty.
Did you see any performance improvements?
Did the error you mentioned actually occur?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet