CHEF-14475-Hab path changes for chef-cli #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
Simplecov Report
|
Signed-off-by: nikhil2611 <[email protected]>
lib/chef-cli/helpers.rb
Outdated
| dir = File.expand_path(File.join(paths)) | ||
| raise OmnibusInstallNotFound.new unless dir && File.directory?(dir) | ||
| def get_pkg_prefix | ||
| pkg_name = "ngupta26/chef-cli" # Your origin and package name |
There was a problem hiding this comment.
This could potentially be various origins for the chef-cli pkg?
There was a problem hiding this comment.
Yeah correct, right now I have pushed this under my private origin ngupta26 for testing and installing from there. Going forward It should be something like chef/chef-cli, we will be needing to update these few things once we we publish our packages to the builder through pipelines. Thats why I kept this in draft state as of now.
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
nikhil2611
changed the base branch from
workstation-LTS
to
habitat_pkg_plan_linux
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since moving to habitat component of chef-cli the omnibus_env will not be existing anymore. I have update and created habitat_env and fixed some commands like exec, env to pick hab env instead of omnibus.
Related Issue
https://progresssoftware.atlassian.net/browse/CHEF-14475
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.