Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the chef license commands #224

Merged
merged 15 commits into from
Oct 23, 2024

Conversation

ashiqueps
Copy link

Description

This PR will add the chef license command which can be used to generate the free/trial license for the chef infra. Also if the user has a commercial license, this command can be used to add that as well.

Commands:

  • chef license
  • chef license add
  • chef license list

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@ashiqueps ashiqueps requested review from a team as code owners May 24, 2023 05:03
@damacus
Copy link

damacus commented May 25, 2023

Any guidance on how this will work in CI? Given we're testing 170+ cookbooks I'd really appreciate heads-up on workflow changes like this in the future.

@vkarve-chef
Copy link
Collaborator

@damacus, once generated, a license can be reused across multiple systems. so this can be a one-time activity. you are right about the need for more clarity on adoption of this feature. i'll work with product team to share an overview on community slack so folks have sufficient heads-up.

@damacus
Copy link

damacus commented May 25, 2023

Thanks for the update @vkarve-chef.

If this is going to require a rework on the sous-chefs pipelines again. The only way we're going to be able to do that over the 170 repositories is with Chefs help.

Gemfile Outdated
Comment on lines 39 to 41
source "https://artifactory-internal.ps.chef.co/artifactory/api/gems/omnibus-gems-local/" do
gem "chef-licensing"
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a temporary location for this gem?

Copy link
Author

@ashiqueps ashiqueps Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @ramereth, this is the internal artifactory and will be soon published to RubyGems.

@ashiqueps ashiqueps marked this pull request as draft June 1, 2023 09:22
@ashiqueps ashiqueps force-pushed the CHEF-2616-license-command branch from 0350d74 to 80964c6 Compare July 10, 2023 11:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

1 similar comment
Copy link

@ashiqueps ashiqueps force-pushed the CHEF-2616-license-command branch from d8cac96 to 8d4a1ab Compare October 23, 2024 10:12
Signed-off-by: Ashique Saidalavi <[email protected]>
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps ashiqueps marked this pull request as ready for review October 23, 2024 12:29
@ashiqueps ashiqueps changed the base branch from main to workstation-LTS October 23, 2024 12:30
Copy link

@ashiqueps ashiqueps merged commit b3630a0 into chef:workstation-LTS Oct 23, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants