Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default chdb latest release version to 2.0.0b0 #12

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

jboga
Copy link
Contributor

@jboga jboga commented Jun 11, 2024

When installing chdb-node the default chdb version the update_libchdb.sh script installs is 1.1.0.

This PR bumps that default version to the current latest release of chdb: 1.4.1.

You could comment/un-comment the LATEST_RELEASE variable in the script but I believe most people want to be in control of the chdb version they use.

Also I bumped the chdb-node version to 1.1.4 as I don't think there are any breaking changes between chdb 1.1.0 and 1.4.1 but happy to change it to 1.2.0 if you think it's more appropriate.

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2024

CLA assistant check
All committers have signed the CLA.

@jboga
Copy link
Contributor Author

jboga commented Jun 12, 2024

Sorry I forgot to mention the tests were not passing. And I'm not that familiar with what's happening there 🙁

@auxten
Copy link
Member

auxten commented Jun 12, 2024

Thanks for your PR!
It's some Node FFI issue
As libchdb 1.4.1 will not fix anything in chdb-node. I will fix it after next libchdb release.

@auxten auxten changed the title Bump default chdb latest release version to 1.4.1 Bump default chdb latest release version to 2.0.0b0 Jul 3, 2024
@auxten auxten merged commit 7cb8ee7 into chdb-io:main Jul 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants