-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic modernizations #5
base: master
Are you sure you want to change the base?
Changes from all commits
9c31fd9
f651c4a
99fca66
ca34ee4
b1e4720
b94d184
f5f32e8
dd88e33
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
version: 2 | ||
|
||
updates: | ||
- package-ecosystem: "pip" | ||
directory: "/" | ||
schedule: | ||
interval: "weekly" | ||
|
||
- package-ecosystem: "github-actions" | ||
directory: "/" | ||
schedule: | ||
interval: "monthly" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
--- | ||
name: Tests | ||
|
||
on: | ||
pull_request: ~ | ||
push: | ||
branches: [ master ] | ||
|
||
# Allow job to be triggered manually. | ||
workflow_dispatch: | ||
|
||
# Cancel in-progress jobs when pushing to the same branch. | ||
concurrency: | ||
cancel-in-progress: true | ||
group: ${{ github.workflow }}-${{ github.ref }} | ||
|
||
jobs: | ||
|
||
tests: | ||
|
||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: ["ubuntu-20.04"] | ||
python-version: ["3.6", "3.11"] | ||
|
||
env: | ||
OS: ${{ matrix.os }} | ||
PYTHON: ${{ matrix.python-version }} | ||
|
||
name: Python ${{ matrix.python-version }} on OS ${{ matrix.os }} | ||
steps: | ||
|
||
- name: Acquire sources | ||
uses: actions/checkout@v4 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
architecture: x64 | ||
cache: 'pip' | ||
cache-dependency-path: | | ||
setup.cfg | ||
setup.py | ||
|
||
- name: Set up project | ||
run: | | ||
|
||
# Adjust baseline dependencies. | ||
pip install --prefer-binary --upgrade --requirement=requirements-dev.txt | ||
|
||
# Install package in editable mode. | ||
pip install --prefer-binary --editable=.[develop] | ||
|
||
# Needs to be invoked manually upfront. | ||
# https://github.com/python/mypy/issues/11103 | ||
mypy --install-types --non-interactive pytest_crate | ||
|
||
- name: Run linters and software tests | ||
run: | | ||
pytest --cov pytest_crate -vvvs | ||
coverage xml | ||
|
||
- name: Upload coverage to Codecov | ||
uses: codecov/codecov-action@v3 | ||
with: | ||
files: ./coverage.xml | ||
flags: unittests | ||
env_vars: OS,PYTHON | ||
name: codecov-umbrella | ||
fail_ci_if_error: false |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
pip<23 | ||
setuptools<70 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ | |
|
||
@pytest.fixture(scope="session") | ||
def custom_crate_a(crate_layer): | ||
yield from crate_layer("crate_a", "3.2.x") | ||
yield from crate_layer("crate_a", "5.4.x") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI: When using CrateDB 3.2 today, the test case fails with:
It is probably related to a more recent version of /cc @mfussenegger, @seut |
||
|
||
|
||
@pytest.fixture(scope="session") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package is constantly used on a few projects, so I think it deserves to get the "Beta" status, at least ;], or even a higher ranking.