-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade fontawesome libs for fix defaultProps warning #152
base: master
Are you sure you want to change the base?
Conversation
@supersnager Can you review PR, please? |
I guess these changes are ok ! when can we get this changes merged ? |
I can't merge this PR because I've not permissions for to do it. I just may comment or close this PR |
Please keep open. I don't know the status of this project, but your fix is helpful to me. Thanks. |
@Zakariaels could you approve the pull request to fix the annoying defaultProps warning please? This is a great library but having such issue really makes it less attractive. |
@vincenttat22, I don't have the 'write access' to this repository in order to merge this PR. |
@Zakariaels thanks for the review. I guess only @supersnager can merge this change. |
I will merge it after holidays |
@supersnager can you please give a timeframe on when you plan to merge this fix? thanks |
I've been desperately asking the author to merge the change for a month. I really feel like this library has been abandoned. |
Yeah, if it's depreciate that will not do the case. In my case in a student project that can do the case because that heppen when i have already a big part of the interface made. but for professional project that can be not the best thing to have depreciate warning in the console log. |
What a shame! It is a good library. The author could have just merged the pr then problem solved. Why is it too difficult for them to click a button to approve this pr? |
#151