-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fallback to common defaults #745
base: master
Are you sure you want to change the base?
Conversation
I was testing the same thing, passing the common to updateElements. |
This is not really optimal, feel free to create better alternative:
|
I don't know how but I'm gonna think about. ;) EDIT: Maybe moving more options in common defaults, the size could be decrease, at least close the current size. |
Maybe its tolerable now:
Would need to do this somehow without |
just thinking loud, could we use the proxies created by CHART,JS instead of the simple objects (which needs deep merge)? |
I don't recall anymore why we are resolving the options to simple objects. But the proxy probably has a list of all the keys resolvable. Lets see. |
I'm using your branch locally to do some tests. I can confirm you that it doesn't need to set |
Having done some tests, this PR can address to centralized common options in the common but it doesn't solve the issues about duplication of code of callout (for instance). |
There are some issues still with the fallback definitions, I'll test some more to be sure what's wrong. |
|
As reply to: #740 (comment)
I'm sure I missed some common options, but those can be added in subsequent pull requests.