feat(spinner): add Output method to expose overwriting the output #405
+95
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only applies under Accessible mode (which seems to be the original intention), leaving the tea program writing to Stderr. The reason for this is under some environments it may be preferable to have Accessible write to stderr - Our usecase is that the spinner produces some json output that is piped to `jq` in some automated environments, but also availble as a CLI for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows callers to override the output used and fixes a line where stdout was always used.
This only applies under Accessible mode (which seems to be the original intention), leaving the tea program writing to Stderr.
The reason for this is under some environments it may be preferable to have Accessible write to stderr - Our usecase is that the spinner produces some json output that is piped to
jqin some automated environments, but also availble as a CLI for users.