feat(spin): Add support for --show-error for the spinner.
#440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that if the `--show-error` flag is provided then the full output of the command will be printed if the command fails. This kind of works in conjuncture with `--show-output` in that if the command succeeds only STDOUT is pushed. If the command fails both `STDOUT` and `STDERR` are pushed. This builds off of charmbracelet#371 Resolves charmbracelet#55
elliotcourant
commented
Oct 14, 2023
Comment on lines
+65
to
+66
| stdout := io.MultiWriter(&bothbuf, &errbuf) | ||
| stderr := io.MultiWriter(&bothbuf, &outbuf) |
There was a problem hiding this comment.
By doing this the bothbuf will have the output of both STDERR and STDOUT but it will be in the order it was written by the process.
If we have the buffers entirely separate and the writes to each were interleaved in any way, this might cause the output to be confusing or be inaccurate.
|
I would really like to have this feature in gum, can I help to get it merged? |
|
This PR has been taken over in #518 |
maaslalani
pushed a commit
that referenced
this pull request
Mar 28, 2024
… (#518) * feat(spin): Add support for `--show-error` for the spinner. This makes it so that if the `--show-error` flag is provided then the full output of the command will be printed if the command fails. This kind of works in conjuncture with `--show-output` in that if the command succeeds only STDOUT is pushed. If the command fails both `STDOUT` and `STDERR` are pushed. This builds off of #371 Resolves #55 * chore: Fix formatting --------- Co-authored-by: Elliot Courant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that if the
--show-errorflag is provided then thefull output of the command will be printed if the command fails. This
kind of works in conjuncture with
--show-outputin that if the commandsucceeds only STDOUT is pushed. If the command fails both
STDOUTandSTDERRare pushed.This builds off of #371
Resolves #55
Fixes #55
Changes
--show-errorflag for the spinner command.Examples