Skip to content

fix: renderer: keep a separate count of lines rendered in the alt screen #3828

fix: renderer: keep a separate count of lines rendered in the alt screen

fix: renderer: keep a separate count of lines rendered in the alt screen #3828

Triggered via pull request November 22, 2024 20:02
Status Success
Total duration 2m 36s
Artifacts

lint.yml

on: pull_request
Matrix: lint / lint-soft
Matrix: lint / lint
Fit to window
Zoom out
Zoom in

Annotations

30 errors and 6 warnings
lint / lint-soft (ubuntu-latest): options.go#L189
`noticable` is a misspelling of `noticeable` (misspell)
lint / lint-soft (ubuntu-latest): logging.go#L36
Magic number: 0o600, in <argument> detected (mnd)
lint / lint-soft (ubuntu-latest): tty.go#L55
Magic number: 10, in <argument> detected (mnd)
lint / lint-soft (ubuntu-latest): tty.go#L107
Magic number: 500, in <argument> detected (mnd)
lint / lint-soft (ubuntu-latest): mouse.go#L175
Magic number: 5, in <condition> detected (mnd)
lint / lint-soft (ubuntu-latest): key.go#L625
Magic number: 3, in <operation> detected (mnd)
lint / lint-soft (ubuntu-latest): key_sequences.go#L126
Magic number: 3, in <return> detected (mnd)
lint / lint-soft (ubuntu-latest): key_sequences.go#L128
Magic number: 3, in <return> detected (mnd)
lint / lint-soft (ubuntu-latest): inputreader_other.go#L13
error returned from external package is unwrapped: sig: func github.com/muesli/cancelreader.NewReader(reader io.Reader) (github.com/muesli/cancelreader.CancelReader, error) (wrapcheck)
lint / lint-soft (ubuntu-latest): key_sequences.go#L122
directive `// nolint: gomnd` should be written without leading space as `//nolint: gomnd` (nolintlint)
lint / lint-soft (macos-latest): options.go#L189
`noticable` is a misspelling of `noticeable` (misspell)
lint / lint-soft (macos-latest): logging.go#L36
Magic number: 0o600, in <argument> detected (mnd)
lint / lint-soft (macos-latest): tty.go#L55
Magic number: 10, in <argument> detected (mnd)
lint / lint-soft (macos-latest): tty.go#L107
Magic number: 500, in <argument> detected (mnd)
lint / lint-soft (macos-latest): mouse.go#L175
Magic number: 5, in <condition> detected (mnd)
lint / lint-soft (macos-latest): key.go#L625
Magic number: 3, in <operation> detected (mnd)
lint / lint-soft (macos-latest): key_sequences.go#L126
Magic number: 3, in <return> detected (mnd)
lint / lint-soft (macos-latest): key_sequences.go#L128
Magic number: 3, in <return> detected (mnd)
lint / lint-soft (macos-latest): inputreader_other.go#L13
error returned from external package is unwrapped: sig: func github.com/muesli/cancelreader.NewReader(reader io.Reader) (github.com/muesli/cancelreader.CancelReader, error) (wrapcheck)
lint / lint-soft (macos-latest): key_sequences.go#L122
directive `// nolint: gomnd` should be written without leading space as `//nolint: gomnd` (nolintlint)
lint / lint-soft (windows-latest): options.go#L189
`noticable` is a misspelling of `noticeable` (misspell)
lint / lint-soft (windows-latest): key_windows.go#L147
missing cases in switch of type tea.MouseButton: tea.MouseButtonNone, tea.MouseButtonWheelUp, tea.MouseButtonWheelDown, tea.MouseButtonWheelLeft, tea.MouseButtonWheelRight, tea.MouseButton10, tea.MouseButton11 (exhaustive)
lint / lint-soft (windows-latest): key_windows.go#L190
missing cases in switch of type coninput.VirtualKeyCode: coninput.VK_LBUTTON, coninput.VK_RBUTTON, coninput.VK_CANCEL, coninput.VK_MBUTTON, coninput.VK_XBUTTON1, coninput.VK_XBUTTON2, coninput.VK_CLEAR, coninput.VK_SHIFT, coninput.VK_CONTROL, coninput.VK_MENU, coninput.VK_PAUSE, coninput.VK_CAPITAL, coninput.VK_KANA|coninput.VK_HANGEUL|coninput.VK_HANGUL, coninput.VK_IME_ON, coninput.VK_JUNJA, coninput.VK_FINAL, coninput.VK_HANJA|coninput.VK_KANJI, coninput.VK_IME_OFF, coninput.VK_CONVERT, coninput.VK_NONCONVERT, coninput.VK_ACCEPT, coninput.VK_MODECHANGE, coninput.VK_SELECT, coninput.VK_PRINT, coninput.VK_EXECUTE, coninput.VK_SNAPSHOT, coninput.VK_INSERT, coninput.VK_HELP, coninput.VK_0, coninput.VK_1, coninput.VK_2, coninput.VK_3, coninput.VK_4, coninput.VK_5, coninput.VK_6, coninput.VK_7, coninput.VK_8, coninput.VK_9, coninput.VK_A, coninput.VK_B, coninput.VK_C, coninput.VK_D, coninput.VK_E, coninput.VK_F, coninput.VK_G, coninput.VK_H, coninput.VK_I, coninput.VK_J, coninput.VK_K, coninput.VK_L, coninput.VK_M, coninput.VK_N, coninput.VK_O, coninput.VK_P, coninput.VK_Q, coninput.VK_R, coninput.VK_S, coninput.VK_T, coninput.VK_U, coninput.VK_V, coninput.VK_W, coninput.VK_X, coninput.VK_Y, coninput.VK_Z, coninput.VK_LWIN, coninput.VK_RWIN, coninput.VK_APPS, coninput.VK_SLEEP, coninput.VK_NUMPAD0, coninput.VK_NUMPAD1, coninput.VK_NUMPAD2, coninput.VK_NUMPAD3, coninput.VK_NUMPAD4, coninput.VK_NUMPAD5, coninput.VK_NUMPAD6, coninput.VK_NUMPAD7, coninput.VK_NUMPAD8, coninput.VK_NUMPAD9, coninput.VK_MULTIPLY, coninput.VK_ADD, coninput.VK_SEPARATOR, coninput.VK_SUBTRACT, coninput.VK_DECIMAL, coninput.VK_DIVIDE, coninput.VK_F1, coninput.VK_F2, coninput.VK_F3, coninput.VK_F4, coninput.VK_F5, coninput.VK_F6, coninput.VK_F7, coninput.VK_F8, coninput.VK_F9, coninput.VK_F10, coninput.VK_F11, coninput.VK_F12, coninput.VK_F13, coninput.VK_F14, coninput.VK_F15, coninput.VK_F16, coninput.VK_F17, coninput.VK_F18, coninput.VK_F19, coninput.VK_F20, coninput.VK_F21, coninput.VK_F22, coninput.VK_F23, coninput.VK_F24, coninput.VK_NUMLOCK, coninput.VK_SCROLL, coninput.VK_OEM_NEC_EQUAL|coninput.VK_OEM_FJ_JISHO, coninput.VK_OEM_FJ_MASSHOU, coninput.VK_OEM_FJ_TOUROKU, coninput.VK_OEM_FJ_LOYA, coninput.VK_OEM_FJ_ROYA, coninput.VK_LSHIFT, coninput.VK_RSHIFT, coninput.VK_LCONTROL, coninput.VK_RCONTROL, coninput.VK_LMENU, coninput.VK_RMENU, coninput.VK_BROWSER_BACK, coninput.VK_BROWSER_FORWARD, coninput.VK_BROWSER_REFRESH, coninput.VK_BROWSER_STOP, coninput.VK_BROWSER_SEARCH, coninput.VK_BROWSER_FAVORITES, coninput.VK_BROWSER_HOME, coninput.VK_VOLUME_MUTE, coninput.VK_VOLUME_DOWN, coninput.VK_VOLUME_UP, coninput.VK_MEDIA_NEXT_TRACK, coninput.VK_MEDIA_PREV_TRACK, coninput.VK_MEDIA_STOP, coninput.VK_MEDIA_PLAY_PAUSE, coninput.VK_LAUNCH_MAIL, coninput.VK_LAUNCH_MEDIA_SELECT, coninput.VK_LAUNCH_APP1, coninput.VK_LAUNCH_APP2, coninput.VK_OEM_1, coninput.VK_OEM_PLUS, coninput.VK_OEM_COMMA, coninput.VK_OEM_MINUS, coninput.VK_OEM_PERIOD, coninput.VK_OEM_2, coninput.VK_OEM_3, coninput.VK_OEM_4, coninput.VK_OEM_5, coninput.VK_OEM_6, coninput.VK_OEM_7, coninput.VK_OEM_8, coninput.VK_OEM_AX, coninput.VK_OEM_102, coninput.VK_ICO_HELP, coninput.VK_ICO_00, coninput.VK_PROCESSKEY, coninput.VK_ICO_CLEAR, coninput.VK_OEM_RESET, coninput.VK_OEM_JUMP, coninput.VK_OEM_PA1, coninput.VK_OEM_PA2, coninput.VK_OEM_PA3, coninput.VK_OEM_WSCTRL, coninput.VK_OEM_CUSEL, coninput.VK_OEM_ATTN, coninput.VK_OEM_FINISH, coninput.VK_OEM_COPY, coninput.VK_OEM_AUTO, coninput.VK_OEM_ENLW, coninput.VK_OEM_BACKTAB, coninput.VK_ATTN, coninput.VK_CRSEL, coninput.VK_EXSEL, coninput.VK_EREOF, coninput.VK_PLAY, coninput.VK_ZOOM, coninput.VK_NONAME, coninput.VK_PA1, coninput.VK_OEM_CLEAR (exhaustive)
lint / lint-soft (windows-latest): key_windows.go#L344
missing cases in switch of type coninput.VirtualKeyCode: coninput.VK_LBUTTON, coninput.VK_RBUTTON, coninput.VK_CANCEL, coninput.VK_MBUTTON, coninput.VK_XBUTTON1, coninput.VK_XBUTTON2, coninput.VK_BACK, coninput.VK_TAB, coninput.VK_CLEAR, coninput.VK_RETURN, coninput.VK_SHIFT, coninput.VK_CONTROL, coninput.VK_MENU, coninput.VK_PAUSE, coninput.VK_CAPITAL, coninput.VK_KANA|coninput.VK_HANGEUL|coninput.VK_HANGUL, coninput.VK_IME_ON, coninput.VK_JUNJA, coninput.VK_FINAL, coninput.VK_HANJA|coninput.VK_KANJI, coninput.VK_IME_OFF, coninput.VK_ESCAPE, coninput.VK_CONVERT, coninput.VK_NONCONVERT, coninput.VK_ACCEPT, coninput.VK_MODECHANGE, coninput.VK_SPACE, coninput.VK_PRIOR, coninput.VK_NEXT, coninput.VK_END, coninput.VK_HOME, coninput.VK_LEFT, coninput.VK_UP, coninput.VK_RIGHT, coninput.VK_DOWN, coninput.VK_SELECT, coninput.VK_PRINT, coninput.VK_EXECUTE, coninput.VK_SNAPSHOT, coninput.VK_INSERT, coninput.VK_DELETE, coninput.VK_HELP, coninput.VK_0, coninput.VK_1, coninput.VK_2, coninput.VK_3, coninput.VK_4, coninput.VK_5, coninput.VK_6, coninput.VK_7, coninput.VK_8, coninput.VK_9, coninput.VK_A, coninput.VK_B, coninput.VK_C, coninput.VK_D, coninput.VK_E, coninput.VK_F, coninput.VK_G, coninput.VK_H, coninput.VK_I, coninput.VK_J, coninput.VK_K, coninput.VK_L, coninput.VK_M, coninput.VK_N, coninput.VK_O, coninput.VK_P, coninput.VK_Q, coninput.VK_R, coninput.VK_S, coninput.VK_T, coninput.VK_U, coninput.VK_V, coninput.VK_W, coninput.VK_X, coninput.VK_Y, coninput.VK_Z, coninput.VK_LWIN, coninput.VK_RWIN, coninput.VK_APPS, coninput.VK_SLEEP, coninput.VK_NUMPAD0, coninput.VK_NUMPAD1, coninput.VK_NUMPAD2, coninput.VK_NUMPAD3, coninput.VK_NUMPAD4, coninput.VK_NUMPAD5, coninput.VK_NUMPAD6, coninput.VK_NUMPAD7, coninput.VK_NUMPAD8, coninput.VK_NUMPAD9, coninput.VK_MULTIPLY, coninput.VK_ADD, coninput.VK_SEPARATOR, coninput.VK_SUBTRACT, coninput.VK_DECIMAL, coninput.VK_DIVIDE, coninput.VK_F1, coninput.VK_F2, coninput.VK_F3, coninput.VK_F4, coninput.VK_F5, coninput.VK_F6, coninput.VK_F7, coninput.VK_F8, coninput.VK_F9, coninput.VK_F10, coninput.VK_F11, coninput.VK_F12, coninput.VK_F13, coninput.VK_F14, coninput.VK_F15, coninput.VK_F16, coninput.VK_F17, coninput.VK_F18, coninput.VK_F19, coninput.VK_F20, coninput.VK_F21, coninput.VK_F22, coninput.VK_F23, coninput.VK_F24, coninput.VK_NUMLOCK, coninput.VK_SCROLL, coninput.VK_OEM_NEC_EQUAL|coninput.VK_OEM_FJ_JISHO, coninput.VK_OEM_FJ_MASSHOU, coninput.VK_OEM_FJ_TOUROKU, coninput.VK_OEM_FJ_LOYA, coninput.VK_OEM_FJ_ROYA, coninput.VK_LSHIFT, coninput.VK_RSHIFT, coninput.VK_LCONTROL, coninput.VK_RCONTROL, coninput.VK_LMENU, coninput.VK_RMENU, coninput.VK_BROWSER_BACK, coninput.VK_BROWSER_FORWARD, coninput.VK_BROWSER_REFRESH, coninput.VK_BROWSER_STOP, coninput.VK_BROWSER_SEARCH, coninput.VK_BROWSER_FAVORITES, coninput.VK_BROWSER_HOME, coninput.VK_VOLUME_MUTE, coninput.VK_VOLUME_DOWN, coninput.VK_VOLUME_UP, coninput.VK_MEDIA_NEXT_TRACK, coninput.VK_MEDIA_PREV_TRACK, coninput.VK_MEDIA_STOP, coninput.VK_MEDIA_PLAY_PAUSE, coninput.VK_LAUNCH_MAIL, coninput.VK_LAUNCH_MEDIA_SELECT, coninput.VK_LAUNCH_APP1, coninput.VK_LAUNCH_APP2, coninput.VK_OEM_1, coninput.VK_OEM_PLUS, coninput.VK_OEM_COMMA, coninput.VK_OEM_MINUS, coninput.VK_OEM_PERIOD, coninput.VK_OEM_2, coninput.VK_OEM_3, coninput.VK_OEM_5, coninput.VK_OEM_6, coninput.VK_OEM_7, coninput.VK_OEM_8, coninput.VK_OEM_AX, coninput.VK_OEM_102, coninput.VK_ICO_HELP, coninput.VK_ICO_00, coninput.VK_PROCESSKEY, coninput.VK_ICO_CLEAR, coninput.VK_OEM_RESET, coninput.VK_OEM_JUMP, coninput.VK_OEM_PA1, coninput.VK_OEM_PA2, coninput.VK_OEM_PA3, coninput.VK_OEM_WSCTRL, coninput.VK_OEM_CUSEL, coninput.VK_OEM_ATTN, coninput.VK_OEM_FINISH, coninput.VK_OEM_COPY, coninput.VK_OEM_AUTO, coninput.VK_OEM_ENLW, coninput.VK_OEM_BACKTAB, coninput.VK_ATTN, coninput.VK_CRSEL, coninput.VK_EXSEL, coninput.VK_EREOF, coninput.VK_PLAY, coninput.VK_ZOOM, coninput.VK_NONAME, coninput.VK_PA1, coninput.VK_OEM_CLEAR (exhaustive)
lint / lint-soft (windows-latest): key_windows.go#L28
Magic number: 16, in <argument> detected (mnd)
lint / lint-soft (windows-latest): logging.go#L36
Magic number: 0o600, in <argument> detected (mnd)
lint / lint-soft (windows-latest): tty.go#L55
Magic number: 10, in <argument> detected (mnd)
lint / lint-soft (windows-latest): tty.go#L107
Magic number: 500, in <argument> detected (mnd)
lint / lint-soft (windows-latest): tty_windows.go#L59
Magic number: 0o644, in <argument> detected (mnd)
lint / lint-soft (windows-latest): mouse.go#L175
Magic number: 5, in <condition> detected (mnd)
lint / lint-soft (ubuntu-latest)
Restore cache failed: Dependencies file is not found in /home/runner/work/bubbletea/bubbletea. Supported file pattern: go.sum
lint / lint (ubuntu-latest)
Restore cache failed: Dependencies file is not found in /home/runner/work/bubbletea/bubbletea. Supported file pattern: go.sum
lint / lint-soft (macos-latest)
Restore cache failed: Dependencies file is not found in /Users/runner/work/bubbletea/bubbletea. Supported file pattern: go.sum
lint / lint (macos-latest)
Restore cache failed: Dependencies file is not found in /Users/runner/work/bubbletea/bubbletea. Supported file pattern: go.sum
lint / lint (windows-latest)
Restore cache failed: Dependencies file is not found in D:\a\bubbletea\bubbletea. Supported file pattern: go.sum
lint / lint-soft (windows-latest)
Restore cache failed: Dependencies file is not found in D:\a\bubbletea\bubbletea. Supported file pattern: go.sum