Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds a simple debian package on tag #386
base: main
Are you sure you want to change the base?
Builds a simple debian package on tag #386
Changes from 5 commits
6bc79ae
64551da
d5e2302
a08bc58
946f17a
04d4e9b
e69962c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this doing? its running on a linux host and using docker to build
amd64
,arm64
,arm/v7
, andarm/v6
? how does it differ from a matrix build? if it is independent can it be its own.yml
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be put in its own yaml. As first version I put together because was easier to link this job as a dependency of the previous one, I'll split in a separate one.
I used this way to get the build for foreign architecture in an easy and reliable manner. Another one would be to use
gcc
cross-compile capability (and it may be also faster), but with cross-compilation there is a small chance that linking with dynamic library could have some issues.Same thing could be done on macOS (amd64 and arm64) if needed.
The main advantages of building by using this method are:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at dependencies between workflows and it is possible to link them, but it will run only on default branch see notes.
What it can be done is to create a parent workflow that calls in order the child workflows. I'm not sure if it is really helpful for this size, thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a lot of overlap between these steps and
Dockerfile
/script/package.sh
, can this all be done in a single place / script that is leveraged by the two flows?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this package.yml is the old one that I dind't deleted, but it should be merge/substituted with the "foreign-arch" one.
So the final flow should be:
Build OS/arch matrix > package > join all build artifact and pre-release if on PR or release if on tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
calling the generic
script/install_dependencies.sh
would mean fewer changes if this was re-used for a different platformThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this info ends up being hard coded 4 times (
builds.yml
,package.yml
,package.sh
, andDockerfile
). Can this be stored in a single file that is sourced in the other locations?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change correction to
0
or removeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these be set in
install_dependencies.sh
andinstall_macos_dependencies.sh
as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
openssl
a new dependency? should it be included in the install list as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't a new dependency and it is installed by default; it is used by libshout3 if I remember correctly, so probably a hidden one.
On macOS 13 it doesn't have the link created by default, so the build fails because cannot find it (even if it's installed).
I don't know if it's a new default from macOS-13 or if it's a bug in the setup configuration of the worker VM