#527 - Ensure offset is respected in JSON:API. #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fiasco is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
JohnAlbin
approved these changes
Feb 22, 2024
|
@JohnAlbin can this get backported to 1.6? |
fiasco
added a commit
to fiasco/next-drupal
that referenced
this pull request
Feb 23, 2024
JohnAlbin
pushed a commit
that referenced
this pull request
Feb 23, 2024
marcorcau
pushed a commit
to marcorcau/next-drupal
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterGitHub Issue: #527
Code changes need test coverage. If you don't know
how to make tests, check this box to ask for help.
Describe your changes
I've had an issue where we could not build more than 1000 pages in a sitemap in nextjs because we could not paginate JSON:API beyond that point. This seems to be because of this issue.