Fix error on entity canonical page when there is no site resolver. #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for:
examples/*
modules/next
packages/next-drupal
starters/basic-starter
starters/graphql-starter
GitHub Issue: #517
Describe your changes
As mentioned in #517, if you have an entity type configured that does not have a site resolver (or from the UI perspective, preview mode set to None), you get the following error on the canonical entity page:
This is because
HtmlRenderer
assumesgetSiteResolver()
returns aSiteResolverInterface
despite the signature (supported by the UI where you can select none) being:This PR uses a null object accessor and switches to a falsy (empty array or null) check on the result.