fix(next): next_entity_type_config dependencies #620
Conversation
Fixes dependencies in next_entity_type_config for the entity type and bundle being targeted.
|
@mglaman is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
| ], | ||
| ], | ||
| ]); | ||
| self::assertEquals([], $entity_type_config->getDependencies()); |
There was a problem hiding this comment.
Am I misreading this assertion?
If the purpose of calculateDependencies() is to add the proper dependencies to the config, why is the test asserting that getDependencies() is an empty array? How does this test that dependencies are added properly?
There was a problem hiding this comment.
Good question. I can't remember if I left this here to show the test was still failing or what... Or if I wrote the test first and then the fix?
I'll follow back up on this today
save test entity so dependencies are calculated
|
@JohnAlbin I tried running locally, but for some reason all tests fail now. So I wanted to use the CI... but it looks like EDIT: needed to update |
|
Okay, it should be all set, now |
Fixes #599 #282, dependencies in next_entity_type_config for the entity type and bundle being targeted.
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterGitHub Issue: #599
Code changes need test coverage. If you don't know
how to make tests, check this box to ask for help.
Describe your changes
Adds configuration dependency to target entity type and bundle