Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(/starters/graphql-starter): add custom headers to support 4.6.0 r… #598

Merged
merged 5 commits into from
Dec 2, 2023

Conversation

cruno91
Copy link
Contributor

@cruno91 cruno91 commented Nov 17, 2023

This pull request is for: (mark with an "x")

  • examples/*
  • modules/next
  • packages/next-drupal
  • starters/basic-starter
  • starters/graphql-starter
  • Other

GitHub Issue: #588

  • I need help adding tests. (mark with an "x")

Describe your changes

The 4.6.0 release of the GraphQL module for Drupal added checks for the headers' "Content-Type" value in requests. The existing application/vnd.api+json value from next-drupal's client.ts fails those tests so they must be changed to application/json.

Copy link

vercel bot commented Nov 17, 2023

@cruno91 is attempting to deploy a commit to the Chapter Three Team on Vercel.

A member of the Team first needs to authorize it.

@JohnAlbin
Copy link
Collaborator

There are coding formatting issues in the file you modiified.

You can run yarn format to update the code formatting in your local Git clone.

@JohnAlbin JohnAlbin self-assigned this Nov 22, 2023
Copy link

vercel bot commented Dec 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-drupal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2023 7:35pm

Copy link
Collaborator

@JohnAlbin JohnAlbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that the GraphQL-starter fails with 4.6.0 and that this fixes the issue.

@JohnAlbin JohnAlbin merged commit c5c736a into chapter-three:main Dec 2, 2023
9 checks passed
@lukewhitmore
Copy link

Does this also need to be rolled into chapter-three/next-drupal-graphql-starter?

@JohnAlbin
Copy link
Collaborator

@lukewhitmore Yep!

We're going to create an 2.0.0 alpha release very soon when we get the starters fully updated to Next.js v14. #624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants