Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
donor_id
, which would print out all possible donor id values. not just the donor id values for the invalid rows.Changes
self.adata.obs.loc[invalid_rows, "donor_id"]
will only fetch the donor_id fields wheninvalid_rows
for that index is true. so this will only print out the donor ids that are actually invalidTesting
i tested this by just printing out the error log in
test_genetic_ancestry_same_donor_id
. previously, this error message would sayERROR: obs rows with donor ids ['donor_1', 'donor_2']
. however, this should beERROR: obs rows with donor ids ['donor_1']
because the way that this test is set up, onlydonor_1
has invalid valuesNotes for Reviewer