Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(callout): new hideTitle and hideBody props and a component slot #910

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

masoudmanson
Copy link
Contributor

Summary

Callout
Github issue: #909

Refactor the Callout component with the following updates:

  • Add a component slot for extraContent, allowing additional content to be placed at the bottom of the Callout component.
  • Introduce two new props to toggle the visibility of the calloutTitle and calloutText.

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson linked an issue Nov 26, 2024 that may be closed by this pull request
@masoudmanson masoudmanson self-assigned this Nov 26, 2024
@masoudmanson masoudmanson added Ready for review This PR is ready for review and removed Work in Progress This PR is a work in progress labels Nov 27, 2024
Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @masoudmanson! Once you get the alignment of the title with the icon when there's no body text updated it will be good to go

@masoudmanson
Copy link
Contributor Author

Looks great @masoudmanson! Once you get the alignment of the title with the icon when there's no body text updated it will be good to go

Thanks so much, @clarsen-czi! I’ve updated the title styles. Let me know if they need further refactoring or if we’re good to go! 🥳🎉🙏🏻

Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @masoudmanson! Thanks for the fix!

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Thanks so much for the upgrade, @masoudmanson 🤩 🙏

Just one small non blocking discussion 😁 Thanks again!

@masoudmanson masoudmanson merged commit 26a830b into main Dec 18, 2024
10 checks passed
@masoudmanson masoudmanson deleted the 909-refactor-callout-component branch December 18, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Eng P0 Ready for review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Callout component
3 participants