-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(callout): new hideTitle and hideBody props and a component slot #910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @masoudmanson! Once you get the alignment of the title with the icon when there's no body text updated it will be good to go
Thanks so much, @clarsen-czi! I’ve updated the title styles. Let me know if they need further refactoring or if we’re good to go! 🥳🎉🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @masoudmanson! Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic! Thanks so much for the upgrade, @masoudmanson 🤩 🙏
Just one small non blocking discussion 😁 Thanks again!
Summary
Callout
Github issue: #909
Refactor the
Callout
component with the following updates:extraContent
, allowing additional content to be placed at the bottom of theCallout
component.calloutTitle
andcalloutText
.Checklist
defaultTheme.ts
used wherever possible