Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(PUBLISHING): update publish back-merge instruction #2121

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Jan 2, 2025

Add a yarn install in the back-merge step, to account for edge case where next has new package versions committed (yarn will blow up if the installed packages do not match the ones mentioned in yarn.lock/package.json)

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

@booc0mtaco booc0mtaco requested a review from a team January 2, 2025 18:53
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.13%. Comparing base (d77ae83) to head (5bc36dd).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2121   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         114      114           
  Lines        2825     2825           
  Branches      764      764           
=======================================
  Hits         2744     2744           
  Misses         77       77           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 2, 2025

size-limit report 📦

Path Size
components 95.29 KB (0%)
styles 29.85 KB (0%)

@booc0mtaco booc0mtaco requested review from a user and removed request for a team January 6, 2025 17:04
@booc0mtaco
Copy link
Contributor Author

@jeremiah-clothier a quick look at this when you get a sec?

@booc0mtaco booc0mtaco merged commit ca8f551 into next Jan 7, 2025
12 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EDS-1455 branch January 7, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant