Fix reading manifest file when it's only one line and also served by GitHub #1323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason changing the size of our manifest file has broken our code to read it. It has something to do with how the file is encoded. I believe it is related to fsspec/filesystem_spec#389.
The issue only comes up due to some handling of partial reads. So I switched to doing a full read since the file is never that large.
We use fsspec instead of requests since sometimes we read a local file or one from s3.