Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] option to return csr tensors in datapipe #1062

Closed
wants to merge 1 commit into from

Conversation

martinkim0
Copy link
Contributor

BREAKING CHANGE: replaces return_sparse_X argument with X_format that allows to specify the sparse format. default is kept to dense.

closes #617

@ebezzi ebezzi requested a review from atolopko-czi April 1, 2024 18:36
@prathapsridharan
Copy link
Contributor

@atolopko-czi @martinkim0 @pablo-gar - There has been no activity on the PR. Was this forgotten?

@atolopko-czi
Copy link
Collaborator

@atolopko-czi @martinkim0 @pablo-gar - There has been no activity on the PR. Was this forgotten?

It still needs to be reviewed & completed.

@ebezzi ebezzi self-assigned this Apr 26, 2024
@ebezzi
Copy link
Member

ebezzi commented Apr 26, 2024

I'll do some cleanup to make sure the CI/CD is green and then I'll merge.

@metakuni metakuni requested a review from ebezzi April 28, 2024 17:19
Copy link

This PR has not seen any activity in the past 4 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed.

@github-actions github-actions bot added the Stale label May 27, 2024
@prathapsridharan
Copy link
Contributor

@ebezzi - note above automated message to close this PR. This comment serves to tell the automated closer to not close it :)

@github-actions github-actions bot removed the Stale label Jul 26, 2024
Copy link

This PR has not seen any activity in the past 4 weeks; if no one comments or reviews it in the next 3 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Aug 23, 2024
Copy link

This PR was closed because it has been inactive for 31 days, 3 days since being marked as stale. Please re-open if you still need this to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to specify output sparse format in ExperimentDataPipe
4 participants