Fix embassy hangs #72
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwanner
reviewed
Dec 1, 2024
There was a problem hiding this comment.
@andelf I can confirm this fixes the blinky examples that use embassy. At least for three devices I tested successfully: ch32v302, ch32x035, and ch32l103.
However, I think this means the entire comment above the function is wrong and needs to be corrected.
I added debug outputs in the two relevant init routines and tried all four variants for configuring WFITOWFE and SEVONPEND. And embassy based blinking only ever worked with both enabled (following from a ch32l103, but other chips showed same results):
no good, no LED blinking:
2024-11-30 23:27:01.044: post qingke_setup_interrupts state: (00000000)
2024-11-30 23:27:01.050: after ch32-hal embassy init: (00000010)
2024-11-30 23:27:39.990: post qingke_setup_interrupts state: (00000000)
2024-11-30 23:27:39.996: after ch32-hal embassy init: (00000000)
2024-11-30 23:28:04.196: post qingke_setup_interrupts state: (00000008)
2024-11-30 23:28:04.202: after ch32-hal embassy init: (00000008)
All good on ch32l103, LED blinking:
2024-11-30 23:28:19.617: post qingke_setup_interrupts state: (00000008)
2024-11-30 23:28:19.623: after ch32-hal embassy init: (00000018)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs more investigation.
At least x035 works now.
Fix #71