Fix USB Interrupt Wiring #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USBFS/OTG_FS actually fire the "GLOBAL" interrupt for WAKEUP. the USB_WAKEUP is for USBD.
Codetector1374
commented
Sep 30, 2024
| @@ -15,8 +15,10 @@ | |||
| register: AHBRSTR | |||
| field: USBHSRST | |||
| interrupts: | |||
| - { "signal": "GLOBAL", "interrupt": "USBHS" } | |||
| - { "signal": "WAKEUP", "interrupt": "USBHS_WKUP" } | |||
| - signal: GLOBAL | |||
There was a problem hiding this comment.
Pure style change while we are here.
|
This should be ready to review / merged. Mostly added some enum so things are a bit easier to use / no magic constants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have verified the global interrupt is the one that actually fires.
The LP/HP interrupt is for USBD, which does not exist on V30x chips.
I am pretty sure the USB_WAKEUP one is for USBD not FS/OTG. Have verified on wakeup / suspend, the main
OTG_FSinterrupt is fired.