Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various improvements #910

Merged
merged 5 commits into from
Jan 13, 2025
Merged

various improvements #910

merged 5 commits into from
Jan 13, 2025

Conversation

EvanBldy
Copy link
Member

Problem

  • Some requirements are outdated.
  • Refactoring on event_stream is needed + there's an error sometimes : ERROR in event_stream: set_application_routes..disconnected() takes 0 positional arguments but 1 was given
  • There's no route to batch comments for different tasks.
  • There's an error when parsing fps from a preview file ("ValueError: could not convert string to float: ''"") when entity["data"]["fps"] is an empty string.

Solution

  • Upgrade outdated requirements.
  • Refactoring for event_stream + fix error.
  • Add new route to batch comments for different tasks : "/actions/tasks/batch-comment" + refactoring.
  • Fix error when parsing fps from a preview file : ignore empty string in entity["data"]["fps"].

@EvanBldy EvanBldy merged commit 36b9e02 into cgwire:main Jan 13, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant