Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #1632

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Various fixes #1632

merged 5 commits into from
Dec 20, 2024

Conversation

NicoPennec
Copy link
Member

Problem

  • The Automations settings page for production is broken.
  • When posting a new comment on a task, if the request fails, the form data is lost.
  • The preview version selected on the task is no longer synchronized between the sidebar and the full screen.

Solution

  • Fix data loading of automation. Issue due to a wrong cache access.
  • Improve the task comment form. Clear comment form only on post successful.
  • Fix synchronization of the selected preview version. Issue due to a wrong migration code to Vue 3.

@NicoPennec NicoPennec merged commit 6935e03 into cgwire:main Dec 20, 2024
6 checks passed
@NicoPennec NicoPennec mentioned this pull request Dec 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frankrousseau frankrousseau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicoPennec @frankrousseau