Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared backgrounds for 3D model previews #1230

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

NicoPennec
Copy link
Member

@NicoPennec NicoPennec commented Oct 28, 2023

Problem

  • On 3D model preview, the uploaded background (skybox) is applied temporarily.

Solution

  • Create a new Backgrounds section in the Admin menu to set global HDRi backgrounds.
  • Create a new Backgrounds tab in the project settings to manage a list of available backgrounds.
  • Add a background selector on 3D model preview player.

@NicoPennec NicoPennec force-pushed the feat/shared-backgrounds branch from 45335f8 to ec5f1e0 Compare November 7, 2023 10:57
@NicoPennec NicoPennec changed the title WIP[settings] add shared backgrounds to 3D model preview [WIP] Shared backgrounds on 3D model preview Nov 7, 2023
@NicoPennec NicoPennec changed the title [WIP] Shared backgrounds on 3D model preview [WIP] Shared backgrounds on 3D model previews Nov 7, 2023
@NicoPennec NicoPennec force-pushed the feat/shared-backgrounds branch from ed6ef51 to 800b301 Compare November 10, 2023 10:17
@NicoPennec NicoPennec force-pushed the feat/shared-backgrounds branch from bae5b1d to 7ff0ff4 Compare November 10, 2023 14:16
@NicoPennec NicoPennec changed the title [WIP] Shared backgrounds on 3D model previews Shared backgrounds for 3D model previews Nov 10, 2023
@NicoPennec NicoPennec marked this pull request as ready for review November 10, 2023 14:17
@frankrousseau frankrousseau merged commit bc20d8b into cgwire:master Nov 10, 2023
5 checks passed
@frankrousseau
Copy link
Contributor

Thank you!

@NicoPennec NicoPennec deleted the feat/shared-backgrounds branch November 10, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants