Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[task] fix upload multi previews #1225

Merged
merged 2 commits into from
Oct 23, 2023
Merged

[task] fix upload multi previews #1225

merged 2 commits into from
Oct 23, 2023

Conversation

NicoPennec
Copy link
Member

@NicoPennec NicoPennec commented Oct 20, 2023 •
edited
Loading

Problem

  • On task panel, if you upload multi preview files when publishing a new revision, only the first preview is uploaded.

Solution

  • Use the preview list from local scope, instead of the preview list from the state.
    In addition, on realtime update, do not clear the list of files being downloaded.

@NicoPennec NicoPennec marked this pull request as ready for review October 23, 2023 10:14
@NicoPennec NicoPennec merged commit c8397ea into cgwire:master Oct 23, 2023
4 checks passed
@NicoPennec NicoPennec deleted the fix/upload-previews branch October 23, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frankrousseau frankrousseau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicoPennec @frankrousseau