Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refreshing of production list #1222

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix refreshing of production list #1222

merged 1 commit into from
Nov 14, 2023

Conversation

NicoPennec
Copy link
Member

@NicoPennec NicoPennec commented Oct 18, 2023 •
edited
Loading

Problem

  • On the Productions page, after reopening a production, the updated item is not visible in the open production list.

Solution

  • Refactor the way to update the productions list to fix the reactivity issues.

@frankrousseau
Copy link
Contributor

@NicoPennec is this PR still relevant?

@NicoPennec
Copy link
Member Author

@frankrousseau Yes, but it's incomplete. I will finish it promptly!

@NicoPennec
[productions] fix refreshing of list after opening or closing a produ…
e51e9c0 
…ction

Remove legacy code in conflict with realtime update
@NicoPennec NicoPennec changed the title [productions] fix refreshing of list after reopening a production Fix refreshing of production list Nov 14, 2023
@NicoPennec NicoPennec marked this pull request as ready for review November 14, 2023 12:04
@frankrousseau frankrousseau merged commit e2a303a into cgwire:master Nov 14, 2023
5 checks passed
@NicoPennec NicoPennec deleted the fix/production-list branch November 14, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frankrousseau frankrousseau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicoPennec @frankrousseau