Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve production schedule #1219

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

NicoPennec
Copy link
Member

@NicoPennec NicoPennec commented Oct 13, 2023

Problem

  • When loading Production Schedule loading, two backup calls are executed without changing data.
  • In the modal to edit a milestone, a too long name will crash in silent, without error message.
  • UX glitches on add/edit milestone buttons positioned at the start of the month.

Solution

  • Avoid useless save call on init Production Schedule.
  • Add a max length to the milestone name field, and handle error in modal on failure.
  • Rework css of milestone.

@NicoPennec NicoPennec marked this pull request as ready for review October 16, 2023 23:12
@NicoPennec NicoPennec merged commit 619760b into cgwire:master Oct 16, 2023
@NicoPennec NicoPennec deleted the fix/production-schedule branch October 16, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants