New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve studio settings #1217

Merged

NicoPennec merged 1 commit into cgwire:master from NicoPennec:fix/settings

Oct 12, 2023

Member

NicoPennec commented Oct 11, 2023

Problem
On global Settings page:

"hours by day" field can be greater than 24 hours.
you can add a studio logo, but not remove it.

Solution

refactor with and validate fields on submit.
add button to remove the current logo.


          [settings] improve studio settings form

16b68cd

- refactor with <form>
- validate fields on submit
- add Remove Logo action

mergify bot assigned frankrousseau

NicoPennec merged commit 74a5305 into cgwire:master

4 checks passed

NicoPennec deleted the fix/settings branch

October 12, 2023 07:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet