Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: fetch-polyfill init error #28

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix: fetch-polyfill init error #28

merged 1 commit into from
Feb 20, 2024

Conversation

danielghost
Copy link
Contributor

Fixes #19.

Fix

  • Added optional chaining to account for fetch calls without init settings, previously causing an error when checking init.keepalive.

@danielghost danielghost self-assigned this Feb 20, 2024
@oliverfoster
Copy link
Member

oliverfoster commented Feb 20, 2024 •
edited
Loading

It might be wise to remove the polyfills? Unless you need fw<4.4.0 or IE11 compatibility?

https://caniuse.com/?search=fetch
https://caniuse.com/?search=promise
https://caniuse.com/?search=url

History of libraries folder https://github.com/cgkineo/adapt-xAPI/commits/master/libraries
Joe's last update, 7 months ago, was just var > const ES6 conversion. Otherwise they haven't changed in 4 years.

@danielghost
Copy link
Contributor Author

#29 has been raised regarding the polyfills.

Currently the plugin still supports framework >= 3.0.0, but this will change as part of #13.

@oliverfoster oliverfoster merged commit 6ed321e into master Feb 20, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/19 branch February 20, 2024 17:03
github-actions bot pushed a commit that referenced this pull request Feb 20, 2024
@semantic-release-bot
Chore(release): 2.1.4 [skip ci]
b4c6afd 
## [2.1.4](v2.1.3...v2.1.4) (2024-02-20)

### Fix

* added optional chaining to account for fetch calls without optional settings (fixes #19). (#28) ([6ed321e](6ed321e)), closes [#19](#19) [#28](#28)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-replin joe-replin Awaiting requested review from joe-replin

Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetch-polyfill init error
2 participants
@danielghost @oliverfoster