Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add paragraph spacing instruction (fixes #102) #103

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Update: Add paragraph spacing instruction (fixes #102) #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c17776b
add schema paragraph spacing help text
kirsty-hames Nov 30, 2023
9b078fb
add schema paragraph spacing description text
kirsty-hames Nov 30, 2023
ed5a441
add paragraph spacing instruction to README
kirsty-hames Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ It provides visual accessibility improvements.
### Note
* IE11 cannot apply filters. This means that images and videos will not be transformed in IE11.
* All colour transformations are applied by mathematical shifts. It is therefore important that the course start from AA colour contrast for the algorithms to be applicable.
* Invert only inverts brightness, not colour.
* Line height, paragraph spacing, letter spacing and word spacing are all ratio based. 1 is the current value, 1.2 is and uplift by 20%, 0.9 would be a shift downwards by 10%.
* In order to support paragraph spacing, all body text needs to be wrapped in [paragraph tags](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/p).
* Font size medium is the default font size (16px usually), large is 18pt, small is 9pt.
* Invert only inverts brightness, not colour.
* Hide decorative images is contingent on alt text.

----------------------------
Expand Down
3 changes: 2 additions & 1 deletion properties.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,8 @@
"default": true,
"title": "Enable",
"inputType": "Checkbox",
"validators": []
"validators": [],
"help": "Note, in order to support paragraph spacing, all body text needs to be wrapped in paragraph '<p>' tags"
},
"title": {
"type": "string",
Expand Down
1 change: 1 addition & 0 deletions schema/course.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,7 @@
"_paragraphSpacing": {
"type": "object",
"title": "Paragraph spacing",
"description": "Note, in order to support paragraph spacing, all body text needs to be wrapped in paragraph '<p>' tags",
"default": {},
"properties": {
"_isEnabled": {
Expand Down
Loading