Fix: Component not loading/working correctly with newer versions of m…

…edia component (fixes #2 & #7)
cgkineo · Jan 26, 2024 · 8585d6d · 8585d6d
2 parents ca888a9 + 28143c1
commit 8585d6d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 11 deletions.
diff --git a/js/simpleVideoBranchingModel.js b/js/simpleVideoBranchingModel.js
@@ -28,8 +28,14 @@ define([
         }
       });
 
-      // totals are useful to have too
+      // totals are useful to have too, set initial player state attributes
       this.set({
+        _isMediaEnded: false,
+        _isMediaPlaying: false,
+        _media: {
+          cc: [],
+          mp4: ' '// prevent console warning 'No media is selected in components.json'
+        },
         _mediaCount: mediaIndex,
         _questionCount: questionIndex
       });

diff --git a/js/simpleVideoBranchingView.js b/js/simpleVideoBranchingView.js
@@ -18,7 +18,7 @@ define([
       'click .js-svb-transcript-skip-btn': 'skipToQuestionButtonClicked',
       'click .js-svb-results-btn': 'onFinalVideoEnded',
       'click .js-retry-btn': 'onRetryClick'
-    }, Media.view.prototype.events),
+    }, Media.view.prototype.events()),
 
     preRender: function() {
       this.listenTo(Adapt, {
@@ -29,15 +29,6 @@ define([
 
       _.bindAll(this, 'onMediaElementPlay', 'onMediaElementPause', 'onMediaElementEnded', 'onMediaElementTimeUpdate', 'onMediaElementSeeking');
 
-      // set initial player state attributes
-      this.model.set({
-        _isMediaEnded: false,
-        _isMediaPlaying: false,
-        _media: {
-          mp4: ' '// prevent console warning 'No media is selected in components.json'
-        }
-      });
-
       this.checkIfResetOnRevisit?.();
     },