Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add search field label element (fixes #67) #71

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Sep 26, 2023

Fix #67

Fix

  • Adds a <label> element to the search text field. The content will use the description value if set. Otherwise, will fallback to the title and will be for screenreaders only (hidden from view).
  • Removes the drawer item description to avoid duplicate content.

@swashbuck swashbuck self-assigned this Sep 26, 2023
@oliverfoster oliverfoster merged commit 6b6f1c9 into master Sep 27, 2023
@oliverfoster oliverfoster deleted the issue/67 branch September 27, 2023 19:30
github-actions bot pushed a commit that referenced this pull request Sep 27, 2023
## [4.2.6](v4.2.5...v4.2.6) (2023-09-27)

### Fix

* Add search field label element (fixes #67) (#71) ([6b6f1c9](6b6f1c9)), closes [#67](#67) [#71](#71)
@github-actions
Copy link

🎉 This PR is included in version 4.2.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: no label on form
2 participants