Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Check if content object(page) is set to _isOptional and unlock pageNav button if set to _lockUntilPageComplete (fixes #64) #65

Merged
merged 2 commits into from
May 1, 2024

Conversation

StuartNicholls
Copy link
Contributor

Fixes #64

Fix

Checks if content object(page) is set to _isOptional and automatically unlocks the pageNav buttons to _lockUntilPageComplete

Testing

  1. Install the diagnostic plug-in or set the Content Object to _isOptional
  2. Configure pageNav to _lockUntilPageComplete

Account for isOptional set on content object
@StuartNicholls StuartNicholls self-assigned this May 1, 2024
@StuartNicholls StuartNicholls added the bug Something isn't working label May 1, 2024
js/PageNavModel.js Outdated Show resolved Hide resolved
Co-authored-by: Oliver Foster <[email protected]>
@oliverfoster oliverfoster merged commit 3647bf7 into master May 1, 2024
@oliverfoster oliverfoster deleted the issue/64 branch May 1, 2024 13:57
Copy link

github-actions bot commented May 1, 2024

🎉 This PR is included in version 3.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PageNav never unlocks when Page is _isOptional
3 participants